Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring leaderboard #736

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abdelrahmanbasheer
Copy link
Contributor


title: Issue #736 refactored leaderboards page |

Discord Username: @2dudu

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • [ Y] πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

replaced a block of code that had the functionality of viewing the contributors list and added this block into its own component with its own types however I couldn't add a type for "contributorCommitActivities" as it caused a lot of different errors so i left it as any for now

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

  • [ Y] πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant